Immutable props fix (fixes #2433) #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@claviska Just updated to Stencil 2.4.0 and noticed this warning starting to come through my unit tests. I'm not actually mutating any props through my component logic, however, I do mutate props in my unit tests. Is there any way to disable the warning during tests? Or is there a recommended alternative? |
|
My unit tests pass even in 2.0.1 with an error: To pass the tests I needed make all props mutable but it is not the right way. Please, clarify this moment. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a longstanding bug where the warning for immutable prop changes doesn't get shown. It also adds tests to ensure the warning is emitted at the correct times.
Side note: this will probably confuse people once it gets merged because a lot of projects are likely changing props without the
{ mutable: true }flag. I've already noticed a few in Stencil Router. 😆